Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- custom-elements.json: Language not supported
Comments suppressed due to low confidence (1)
src/auto-check-element.ts:112
- [nitpick] The event name 'triggerValidation' should follow a consistent naming convention.
input.addEventListener('triggerValidation', changeHandler)
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
camertron
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method to the web component to manually trigger the auto-check element to validate the input. This is useful for validating pre-populated fields on a form as the auto-check element does not currently validate fields if they have not been changed since load. Using this method, we can force the auto-check element to validate the input as needed.
(For Hubbers) see internal issue: github/new-user-experience#292